docs(dogfood): step 4 requires rebuilding before judging the ablation - #8821
Merged
qq9340100 merged 1 commit intoAug 15, 2026
Merged
Conversation
packages/qa/dogfood resolves the code under test from each package's built dist/, not src/, so reverting a fix without rebuilding leaves the ablation running against the pre-mutation build and staying green — a vacuous test certified as discriminating, invisible to every later CI run. This is the third copy of the procedure (after .claude/agents/ os-dev.md and .claude/skills/dogfood-verification/SKILL.md, both landed in #8365); step 4 now names the same rebuild step and the same scripts/ablation-dist-preflight.mjs pre-flight, plus one extra sentence of why for the human contributor reading this file first. Fixes #8366 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NaS1PAHJcPfAA2acnV53Tn
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 2 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
qq9340100
marked this pull request as ready for review
August 15, 2026 05:10
qq9340100
deleted the
claude/issue-8366-dogfood-readme-ablation-rebuild
branch
August 15, 2026 05:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8366
What
packages/qa/dogfood/README.md, "Adding a golden test" step 4, prescribed theablation procedure (revert the fix, confirm the test goes red) without the
rebuild in between. This suite resolves the code under test from each
package's built
dist/, notsrc/, so a revert without a rebuild leaves theablation running against the pre-mutation build and staying green — a vacuous
test silently certified as discriminating, with no later CI run able to
expose it (CI builds correctly, so it stays green there forever).
This is the third live copy of the same procedure. The other two —
.claude/agents/os-dev.mdand.claude/skills/dogfood-verification/SKILL.md— already carry the rebuild step and the pre-flight script reference, landed
by PR #8365. This PR brings the README copy in line with that landed wording,
plus one extra sentence of why since this file is the copy a human
contributor is most likely to read first.
Change
One clause added to step 4:
pnpm --filter PKG build) between reverting the fixand judging the test's colour;
scripts/ablation-dist-preflight.mjs PKG 'MARKER'(--absentfor a deleted guard) as the pre-flight that proves the mutation actually
reached the built artifact.
(The README itself uses angle-bracket placeholders; they are spelled
PKG/MARKERhere because this description is stored through a sanitizer thatstrips angle-bracket sequences — an earlier revision of this body lost them
silently. The committed file is unaffected; see the diff.)
Verified the script's real path/name/invocation against
origin/mainbeforeciting it (
scripts/ablation-dist-preflight.mjs, confirmed present andmatching the card's citation exactly — no discrepancy). Also read back both
landed copies (
.claude/agents/os-dev.md:229-237,.claude/skills/dogfood-verification/SKILL.md:64-75) to confirm they agreewith each other and with what this PR now adds to the README — no
three-way drift.
Docs-only, no runtime/behavior change. No
.changeset/entry (nothinguser-visible);
skip-changesetapplied.Refs #8246 (closed, discharged the body's
Blocked-by:— not addressedhere), PR #8365.
Tests
Docs-only change; no build/test suite applies. Local gates run at the final
commit (
ab48e32ce, fromnode scripts/pm/dispatch-gates.mjs packages/qa/dogfood/README.md, pluscheck:nul-byteson every edit):